Open
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
approved these changes
Mar 16, 2026
Contributor
superdosh
left a comment
superdosh
left a comment
There was a problem hiding this comment.
This looks good to me overall, though I don't love the name.
wpietri
reviewed
Mar 16, 2026
Contributor
wpietri
left a comment
wpietri
left a comment
There was a problem hiding this comment.
I like the theory, but
- How do we know it works? I'd like to see a test that at least N factories are found under normal run conditions, and
- How do we make sure it keeps working? That is, if somebody adds a new factory, are we sure they'll do the right thing to make sure it shows up?
src/modelgauge/sut_factory.py
Outdated
| def _load_dynamic_sut_factories(self, secrets: RawSecrets) -> dict[str, DynamicSUTFactoryDriver]: | ||
| load_namespace("suts") | ||
| dynamic_sut_factories = {} | ||
| for cls in get_concrete_subclasses(DynamicSUTFactoryDriver): # type: ignore |
Contributor
There was a problem hiding this comment.
My recollection is that in Python this only works for code that has already been imported. With the explicit imports gone, how are we sure that this will actually get everything?
Contributor
Author
There was a problem hiding this comment.
I believe load_namespace("suts") takes care of that.
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
Contributor
Author
|
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.